Skip to content

Functionality change for ArrayCoordinateSequence with inconsistent coordinate types#376

Merged
jodygarnett merged 1 commit into
locationtech:1.16.xfrom
jodygarnett:copy_on_duplicate
Feb 18, 2019
Merged

Functionality change for ArrayCoordinateSequence with inconsistent coordinate types#376
jodygarnett merged 1 commit into
locationtech:1.16.xfrom
jodygarnett:copy_on_duplicate

Conversation

@jodygarnett

Copy link
Copy Markdown
Contributor

Two changes made after discussion of #374

  • ArrayCoordinateSequence will leave null values in place
  • ArrayCoordinateSequence will create a copy of the array if modification is required

@jodygarnett jodygarnett changed the base branch from master to 1.16.x February 18, 2019 22:28
@jodygarnett

Copy link
Copy Markdown
Contributor Author

aside: This will need to be applied to master also :)

}
enforceArrayConsistency( this.coordinates );
else {
this.coordinates = enforceArrayConsistency(coordinates);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This provides the "make a copy if needed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant